Skip to content

Commit

Permalink
fix(type): extend correct interface on AxisLabelBaseOption. close #17363
Browse files Browse the repository at this point in the history


Co-authored-by: Giulio Mazzanti <gmazzanti@protonmail.com>
  • Loading branch information
breizh24 and Giuzzilla committed Oct 21, 2022
1 parent 053f84c commit 34ee0d3
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/coord/axisCommonTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import {
TextCommonOption, LineStyleOption, OrdinalRawValue, ZRColor,
AreaStyleOption, ComponentOption, ColorString,
AnimationOptionMixin, Dictionary, ScaleDataValue, CommonAxisPointerOption
AnimationOptionMixin, Dictionary, ScaleDataValue, CommonAxisPointerOption, LabelOption
} from '../util/types';


Expand Down Expand Up @@ -213,17 +213,14 @@ type LabelFormatters = {
time: TimeAxisLabelFormatterOption
};

interface AxisLabelBaseOption extends Omit<TextCommonOption, 'color'> {
show?: boolean,
interface AxisLabelBaseOption extends Omit<LabelOption, 'color'> {
// Whether axisLabel is inside the grid or outside the grid.
inside?: boolean,
rotate?: number,
// true | false | null/undefined (auto)
showMinLabel?: boolean,
// true | false | null/undefined (auto)
showMaxLabel?: boolean,
margin?: number,
rich?: Dictionary<TextCommonOption>
/**
* If hide overlapping labels.
*/
Expand Down

0 comments on commit 34ee0d3

Please sign in to comment.