Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo): add totalZoom parameter for the georoam event #19837

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

zhaoxinggang
Copy link
Contributor

@zhaoxinggang zhaoxinggang commented Apr 16, 2024

Brief Information

This pull request is in the type of:

  • [] new feature

What does this PR do?

The georoam event of the map component supports the totalZoom parameter, which is used to do some interaction with the linkage business when the chart is resized

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc@47b0f85

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Apr 16, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@echarts-bot echarts-bot bot added PR: doc unchanged PR: awaiting doc Document changes is required for this PR. and removed PR: doc unchanged labels Apr 16, 2024
Copy link

echarts-bot bot commented Apr 16, 2024

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19837@1ad9a08

@Ovilia Ovilia marked this pull request as ready for review April 16, 2024 06:35
@Ovilia Ovilia merged commit 697e798 into apache:master Apr 16, 2024
2 checks passed
Copy link

echarts-bot bot commented Apr 16, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.5.1 milestone Apr 16, 2024
Ovilia added a commit to apache/echarts-doc that referenced this pull request Apr 16, 2024
@plainheart plainheart changed the title georoam supports the totalZoom parameter feat(geo): add totalZoom parameter for the georoam event May 6, 2024
@echarts-bot echarts-bot bot added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants