Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Return value of method without side effect is ignored #2255

Closed
1 of 2 tasks
Alonexc opened this issue Nov 23, 2022 · 0 comments · Fixed by #2259
Closed
1 of 2 tasks

[Enhancement] Return value of method without side effect is ignored #2255

Alonexc opened this issue Nov 23, 2022 · 0 comments · Fixed by #2259
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Nov 23, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java line 119
analysis and explanation:
This code calls a method and ignores the return value.

Describe the solution you'd like

reference:
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Nov 23, 2022
@Alonexc Alonexc mentioned this issue Nov 23, 2022
Open
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label Nov 25, 2022
@weihubeats weihubeats mentioned this issue Nov 26, 2022
Merged
LIU-WEI-git pushed a commit that referenced this issue Nov 27, 2022
@weihubeats
[ISSUE #2255] simplify the code (#2259)
dd2a9e9 
* simplify the code

* format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #2255] simplify the code
2 participants
@xwm1992 @Alonexc