Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Simplify spi usage #2325

Closed
2 tasks done
weihubeats opened this issue Dec 1, 2022 · 0 comments · Fixed by #2326
Closed
2 tasks done

[Enhancement] Simplify spi usage #2325

weihubeats opened this issue Dec 1, 2022 · 0 comments · Fixed by #2326
Assignees
@weihubeats
Labels
enhancement New feature or request

Comments

@weihubeats
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

The use of spi is generally with singleton objects, so we can modify the default value of the isSingleton method in EventMeshSPI to true to simplify the use of

Describe the solution you'd like

The use of spi is generally with singleton objects, so we can modify the default value of the isSingleton method in EventMeshSPI to true to simplify the use of

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@weihubeats weihubeats added the enhancement New feature or request label Dec 1, 2022
@weihubeats weihubeats mentioned this issue Dec 1, 2022
Merged
xwm1992 added a commit that referenced this issue Dec 1, 2022
@xwm1992
Merge pull request #2326 from weihubeats/spi
2734d51 
[ISSUE #2325] Simplify spi usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weihubeats weihubeats

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #2325] Simplify spi usage
1 participant
@weihubeats