Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] metrics in TCP will not reset to zero #2331

Closed
2 tasks done
jackyluo-learning opened this issue Dec 1, 2022 · 0 comments · Fixed by #2332
Closed
2 tasks done

[Bug] metrics in TCP will not reset to zero #2331

jackyluo-learning opened this issue Dec 1, 2022 · 0 comments · Fixed by #2332
Assignees
@jackyluo-learning
Labels
bug Something isn't working

Comments

@jackyluo-learning
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Windows

EventMesh version

master

What happened

when the scheduled task run at a fixed rate to refresh the metrics in TCP server, those metrics will not be reset, which means that the metrics will be accumlated, becoming larger and larger and never be reset to zero when report metrcs server.

How to reproduce

simply run the application and watch the metrics from dashboard (promethus), it will not be zero even through there is no client connect to tcp server.
企业微信截图_16671838415956

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@jackyluo-learning jackyluo-learning added the bug Something isn't working label Dec 1, 2022
jackyluo-learning added a commit to jackyluo-learning/incubator-eventmesh that referenced this issue Dec 1, 2022
@jackyluo-learning
fixed ISSUE apache#2331 metrics in TCP will not be reset to zero
c4ec069
@jackyluo-learning jackyluo-learning mentioned this issue Dec 1, 2022
Merged
xwm1992 added a commit that referenced this issue Dec 1, 2022
@xwm1992
Merge pull request #2332 from jackyluo-learning/bugfix-branch-shadow-1
4e12397 
[ISSUE #2331] metrics in TCP will not be reset to zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackyluo-learning jackyluo-learning

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #2331] metrics in TCP will not be reset to zero jackyluo-learning/incubator-eventmesh
1 participant
@jackyluo-learning