Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Method encodes String bytes without specifying the character encoding [RabbitmqProducerTest] #2348

Closed
2 tasks done
Alonexc opened this issue Dec 1, 2022 · 1 comment · Fixed by #2357
Closed
2 tasks done

[Enhancement] Method encodes String bytes without specifying the character encoding [RabbitmqProducerTest] #2348

Alonexc opened this issue Dec 1, 2022 · 1 comment · Fixed by #2357
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Dec 1, 2022 •
edited by jonyangx
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-connector-plugin/eventmesh-connector-rabbitmq/src/test/java/org/apache/eventmesh/connector/rabbitmq/producer/RabbitmqProducerTest.java line 71
analysis and explanation:
The behavior of the String(byte[] bytes) and String.getBytes() is undefined if the string cannot be encoded in the platform's default charset.

Describe the solution you'd like

reference:
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Dec 1, 2022
@Alonexc Alonexc mentioned this issue Dec 1, 2022
Open
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label Dec 1, 2022
@jonyangx
Copy link
Contributor

jonyangx commented Dec 2, 2022

I fix it.

@xwm1992 xwm1992 mentioned this issue Dec 2, 2022
Merged
xwm1992 added a commit that referenced this issue Dec 2, 2022
@xwm1992
Merge pull request #2357 from jonyangx/issue2348
bdbdc0d 
[ISSUE #2348] Method encodes String bytes without specifying the character encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #2348] Method encodes String bytes without specifying the character encoding
3 participants
@jonyangx @xwm1992 @Alonexc