-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #1243] Upgrade pravega connector #1237
[ISSUE #1243] Upgrade pravega connector #1237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
============================================
- Coverage 10.47% 10.45% -0.03%
+ Complexity 768 764 -4
============================================
Files 435 432 -3
Lines 26554 26550 -4
Branches 2924 2928 +4
============================================
- Hits 2782 2776 -6
- Misses 23511 23513 +2
Partials 261 261
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@LIU-WEI-git please split into several smaller pr. |
33407e0
to
b613885
Compare
Hi, I have split this PR and started PR #1240 and PR #1242. Please review them. |
b613885
to
fa1d895
Compare
58fa3e2
to
cb09085
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes issue #1243. Related PR #1203.
Motivation
Upgrade pravega connector
Modifications
{consumerGroup}-{topic}
for clustering model or UUID for broadcast model as ReaderGroup nameAUTOMATIC_RELEASE_AT_LAST_CHECKPOINT
as the retention strategy of all ReaderGroup