Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1243] Upgrade pravega connector #1237

Merged
merged 3 commits into from
Sep 23, 2022

Conversation

LIU-WEI-git
Copy link
Contributor

@LIU-WEI-git LIU-WEI-git commented Sep 8, 2022

Fixes issue #1243. Related PR #1203.

Motivation

Upgrade pravega connector

Modifications

  • SubscribeTask supports EventMeshAsyncConsumeContext.commit
  • Consumer support broadcast and clustering message model
  • Upgrade the creation of ReaderGroup and Reader.
    • Use {consumerGroup}-{topic} for clustering model or UUID for broadcast model as ReaderGroup name
    • Set AUTOMATIC_RELEASE_AT_LAST_CHECKPOINT as the retention strategy of all ReaderGroup

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1237 (6f60a8d) into master (49a32d7) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 6f60a8d differs from pull request most recent head cb09085. Consider uploading reports for the commit cb09085 to get more accurate results

@@             Coverage Diff              @@
##             master    #1237      +/-   ##
============================================
- Coverage     10.47%   10.45%   -0.03%     
+ Complexity      768      764       -4     
============================================
  Files           435      432       -3     
  Lines         26554    26550       -4     
  Branches       2924     2928       +4     
============================================
- Hits           2782     2776       -6     
- Misses        23511    23513       +2     
  Partials        261      261              
Impacted Files Coverage Δ
...entmesh/connector/pravega/PravegaConsumerImpl.java 0.00% <0.00%> (ø)
...entmesh/connector/pravega/PravegaProducerImpl.java 0.00% <0.00%> (ø)
...ntmesh/connector/pravega/client/PravegaClient.java 0.00% <0.00%> (ø)
...entmesh/connector/pravega/client/PravegaEvent.java 0.00% <ø> (ø)
...ntmesh/connector/pravega/client/SubscribeTask.java 0.00% <0.00%> (ø)
...tandalone/broker/task/HistoryMessageClearTask.java 29.41% <0.00%> (-17.65%) ⬇️
...mesh/connector/standalone/broker/MessageQueue.java 32.46% <0.00%> (-7.80%) ⬇️
.../admin/handler/QueryRecommendEventMeshHandler.java 90.32% <0.00%> (-2.28%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qqeasonchen
Copy link
Contributor

@LIU-WEI-git please split into several smaller pr.

@LIU-WEI-git LIU-WEI-git force-pushed the pravega_connector_upgrade branch from 33407e0 to b613885 Compare September 8, 2022 14:44
@LIU-WEI-git
Copy link
Contributor Author

@LIU-WEI-git please split into several smaller pr.

Hi, I have split this PR and started PR #1240 and PR #1242. Please review them.

@LIU-WEI-git LIU-WEI-git changed the title [ISSUE #270] Upgrade pravega connector [ISSUE #1243] Upgrade pravega connector Sep 9, 2022
@LIU-WEI-git LIU-WEI-git force-pushed the pravega_connector_upgrade branch from b613885 to fa1d895 Compare September 9, 2022 01:49
@LIU-WEI-git LIU-WEI-git force-pushed the pravega_connector_upgrade branch from 58fa3e2 to cb09085 Compare September 22, 2022 06:00
Copy link
Contributor

@qqeasonchen qqeasonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqeasonchen qqeasonchen merged commit 2232648 into apache:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants