Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1247]add catalog protocol #1249

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[ISSUE#1247]add catalog protocol #1249

merged 1 commit into from
Sep 12, 2022

Conversation

walterlife
Copy link
Contributor

Fixes #1247

Motivation

Applications can access the EventMesh Workflow/AysncAPI capabilities through the EventMesh SDK to fill the event governance capabilities

Modifications

add catalog protocol into eventmesh-common module

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@walterlife walterlife changed the title [#1247]add catalog protocol [ISSUE#1247]add catalog protocol Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1249 (679de46) into master (73ff23e) will decrease coverage by 0.54%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1249      +/-   ##
============================================
- Coverage     11.29%   10.74%   -0.55%     
- Complexity      765      770       +5     
============================================
  Files           421      428       +7     
  Lines         24593    25962    +1369     
  Branches       2685     2857     +172     
============================================
+ Hits           2777     2790      +13     
- Misses        21555    22909    +1354     
- Partials        261      263       +2     
Impacted Files Coverage Δ
...sh/common/protocol/catalog/protos/CatalogGrpc.java 0.00% <0.00%> (ø)
.../protocol/catalog/protos/EventmeshCatalogGrpc.java 0.00% <0.00%> (ø)
...mesh/common/protocol/catalog/protos/Operation.java 0.00% <0.00%> (ø)
...rotocol/catalog/protos/QueryOperationsRequest.java 0.00% <0.00%> (ø)
...otocol/catalog/protos/QueryOperationsResponse.java 0.00% <0.00%> (ø)
...ommon/protocol/catalog/protos/RegistryRequest.java 0.00% <0.00%> (ø)
...mmon/protocol/catalog/protos/RegistryResponse.java 0.00% <0.00%> (ø)
...nnector/standalone/broker/model/MessageEntity.java 44.44% <0.00%> (+5.55%) ⬆️
...mesh/connector/standalone/broker/MessageQueue.java 40.25% <0.00%> (+7.79%) ⬆️
...tandalone/broker/task/HistoryMessageClearTask.java 64.70% <0.00%> (+35.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit a4255ae into apache:master Sep 12, 2022
xwm1992 added a commit to xwm1992/EventMesh that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Adds EventMesh Catalog Protocol
2 participants