Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry zookeeper merge to master branch #2126

Merged
merged 15 commits into from
Nov 8, 2022
Merged

Conversation

xwm1992
Copy link
Contributor

@xwm1992 xwm1992 commented Nov 7, 2022

Fixes #973 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@xwm1992 xwm1992 changed the title Registry zookeeper Registry zookeeper merge to master branch Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #2126 (4dd5e89) into master (c81c366) will increase coverage by 0.37%.
The diff coverage is 76.92%.

@@             Coverage Diff              @@
##             master    #2126      +/-   ##
============================================
+ Coverage     10.85%   11.22%   +0.37%     
- Complexity      816      840      +24     
============================================
  Files           452      455       +3     
  Lines         27443    27599     +156     
  Branches       2989     3002      +13     
============================================
+ Hits           2979     3099     +120     
- Misses        24193    24221      +28     
- Partials        271      279       +8     
Impacted Files Coverage Δ
...registry/zookeeper/constant/ZookeeperConstant.java 0.00% <0.00%> (ø)
...ry/zookeeper/service/ZookeeperRegistryService.java 77.33% <77.33%> (ø)
...esh/registry/zookeeper/pojo/EventMeshInstance.java 80.00% <80.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@qqeasonchen qqeasonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqeasonchen qqeasonchen merged commit 4766fb5 into master Nov 8, 2022
@xwm1992 xwm1992 deleted the registry-zookeeper branch November 25, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] zookeeper registry
2 participants