Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2257] remove interface public keywords #2258

Merged
merged 1 commit into from
Nov 26, 2022
Merged

[ISSUE #2257] remove interface public keywords #2258

merged 1 commit into from
Nov 26, 2022

Conversation

weihubeats
Copy link
Member

Fixes #2257

Motivation

Interface methods are public by default, so you can remove the keyword public

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #2258 (dcb2837) into master (b161bff) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2258   +/-   ##
=========================================
  Coverage     11.74%   11.74%           
  Complexity      897      897           
=========================================
  Files           468      468           
  Lines         27861    27861           
  Branches       3010     3010           
=========================================
  Hits           3272     3272           
  Misses        24290    24290           
  Partials        299      299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 changed the title remote interface public [ISSUE #2257]remote interface public Nov 26, 2022
@xwm1992 xwm1992 changed the title [ISSUE #2257]remote interface public [ISSUE #2257]remove interface public Nov 26, 2022
@xwm1992 xwm1992 changed the title [ISSUE #2257]remove interface public [ISSUE #2257]remove interface public keywords Nov 26, 2022
@xwm1992 xwm1992 changed the title [ISSUE #2257]remove interface public keywords [ISSUE #2257] remove interface public keywords Nov 26, 2022
@xwm1992 xwm1992 merged commit 8ca74a1 into apache:master Nov 26, 2022
@weihubeats weihubeats deleted the remove_public branch November 27, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enchancement] Remove redundant keywords
2 participants