Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2267] Simplify the code #2268

Merged
merged 2 commits into from
Nov 28, 2022
Merged

[ISSUE #2267] Simplify the code #2268

merged 2 commits into from
Nov 28, 2022

Conversation

weihubeats
Copy link
Member

Fixes #2267

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@horoc
Copy link
Member

horoc commented Nov 27, 2022

hi, @weihubeats , thanks for the contribution, there are some check style errors in this pr, could you help to solve the error?

image

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #2268 (f300c20) into master (c6fb147) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #2268   +/-   ##
=========================================
  Coverage     11.74%   11.74%           
  Complexity      897      897           
=========================================
  Files           468      468           
  Lines         27861    27849   -12     
  Branches       3010     3010           
=========================================
  Hits           3272     3272           
+ Misses        24290    24278   -12     
  Partials        299      299           
Impacted Files Coverage Δ
.../client/grpc/config/EventMeshGrpcClientConfig.java 71.42% <0.00%> (+32.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 changed the title Simplify the code [ISSUE #2267] Simplify the code Nov 27, 2022
@xwm1992 xwm1992 merged commit 8b525e5 into apache:master Nov 28, 2022
@weihubeats weihubeats deleted the simplify_code branch November 30, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Simplify the code
3 participants