Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #2349] Method encodes String bytes without specifying the character encoding #2351

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[ISSUE #2349] Method encodes String bytes without specifying the character encoding #2351

merged 1 commit into from
Dec 1, 2022

Conversation

jonyangx
Copy link
Contributor

@jonyangx jonyangx commented Dec 1, 2022 •
edited by xwm1992
Loading

Fixes #2349

Motivation

Method encodes String bytes without specifying the character encoding

Modifications

refactor PravegaClientTest.java line 163

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? ot documented)

@codecov
Copy link

codecov bot commented Dec 1, 2022 •
edited
Loading

Codecov Report

Merging #2351 (6da43b6) into master (2734d51) will not change coverage.
The diff coverage is n/a.

❗ Current head 6da43b6 differs from pull request most recent head 910c022. Consider uploading reports for the commit 910c022 to get more accurate results

@@            Coverage Diff            @@
##             master    #2351   +/-   ##
=========================================
  Coverage     11.69%   11.69%           
  Complexity      891      891           
=========================================
  Files           471      471           
  Lines         27833    27833           
  Branches       3007     3007           
=========================================
  Hits           3254     3254           
  Misses        24280    24280           
  Partials        299      299

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonyangx jonyangx requested a review from LIU-WEI-git December 1, 2022 10:34
horoc
horoc approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@horoc horoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LIU-WEI-git
LIU-WEI-git approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@LIU-WEI-git LIU-WEI-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LIU-WEI-git LIU-WEI-git merged commit a066f79 into apache:master Dec 1, 2022
@jonyangx jonyangx deleted the issue2349 branch December 2, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horoc horoc horoc approved these changes

@LIU-WEI-git LIU-WEI-git LIU-WEI-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Method encodes String bytes without specifying the character encoding [PravegaClientTest]
3 participants
@jonyangx @LIU-WEI-git @horoc