[ISSUE #2576] Tweak Convert's code framework, for ease of enhancement #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1] Split the converter classes in Convert into separate files [2] Add the converter field to ConfigFiled, used to specify the converter class of the field
Codecov Report
@@ Coverage Diff @@
## config-manage-improve #2784 +/- ##
===========================================================
+ Coverage 12.59% 12.71% +0.12%
- Complexity 932 979 +47
===========================================================
Files 488 502 +14
Lines 28465 28515 +50
Branches 3053 3045 -8
===========================================================
+ Hits 3585 3627 +42
- Misses 24565 24575 +10
+ Partials 315 313 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jonyangx
approved these changes
Jan 1, 2023
eight-nines
changed the title
jonyangx
pushed a commit
that referenced
this pull request
Jan 14, 2023
* [ISSUE #2576]Enhancement the config manage for project * [1] test code * EventMeshServer config improve * Extract the key prefix of the @configFiled field into @config * Improve configuration management of SPI implementations [1] config improve of RocketMQProducerImpl and RocketMQConsumerImpl [2] config UT of RocketMQProducerImpl and RocketMQConsumerImpl * Improve configuration management of SPI implementations [1] extensionInstance config init process improve [2] RocketMQProducerImpl and RocketMQConsumerImpl config UT improve * Improve configuration management of Kafka SPI Impl [1] KafkaConsumerImpl and KafkaProducerImpl config improve [2] KafkaConsumerImpl and KafkaProducerImpl config UT * Improve configuration management of Redis SPI Impl [1] RedisProperties config improve * Improve configuration management of Redis SPI Impl [1] RedisProperties config and UT improve [2] New parser ConvertProperties [3] To fix a bug where parser convertEnum could not parse null values * Fix config UT of Redis SPI Impl * Tweak Convert's code framework, for ease of enhancement (#2784) [1] Split the converter classes in Convert into separate files [2] Add the converter field to ConfigFiled, used to specify the converter class of the field * Improve configuration management of Knative SPI Impl (#2791) [1] KnativeConsumerImpl and KnativeProducerImpl config improve [2] KnativeConsumerImpl and KnativeProducerImpl config UT * Improve configuration management of Pravega SPI Impl [1] PravegaConsumerImpl and PravegaProducerImpl config improve [2] PravegaConsumerImpl and PravegaProducerImpl config UT [3] add new converter URIConverter * Improve configuration management of Pulsar SPI Impl [1] PulsarConsumerImpl and PulsarProducerImpl config improve [2] PulsarConsumerImpl and PulsarProducerImpl config UT * Improve configuration management of Rabbitmq SPI Impl [1] RabbitmqConsumer and RabbitmqProducer config improve [2] RabbitmqConsumer and RabbitmqProducer config UT * Improve configuration management of Prometheus SPI Impl [1] PrometheusMetricsRegistry config improve [2] PrometheusMetricsRegistry config UT * Improve configuration management of AuthHttpBasic SPI Impl [1] AuthHttpBasicService config improve [2] AuthHttpBasicService config UT * Enhance configuration management capabilities - @configFiled [1] Add two properties to @configFiled,findEnv / notNull, and the configuration file parsing capabilities that go with them [2] Delete @NotNull and replace it with @ConfigFiled.notNull * Improve configuration management of Pinpoint SPI Impl [1] PinpointTraceService config improve [2] PinpointTraceService config UT * Improve configuration management of Zipkin SPI Impl [1] ZipkinTraceService config improve [2] ZipkinTraceService config UT * Add repeatable functionality to @config For tagging multiple configuration fields on a class * Improve configuration management of TracePlugin [1] ExporterConfiguration config improve [2] ExporterConfiguration config UT * Improve configuration management of WebHook [1] WebHook config improve [2] WebHook config UT * Add field beNumber for @configFiled [1] If String config field not a number, an exception is thrown * Change the configuration management class CommonConfiguration to a new framework [1] Replace the CommonConfiguration field modifier public with private [2] Use getter/setter methods to access it * Change CommonConfiguration subclass to new framework [1] EventMeshHTTPConfiguration/EventMeshGrpcConfiguration/EventMeshTCPConfiguration * Change CommonConfiguration and subclass to new framework [1] EventMeshHTTPConfiguration/EventMeshGrpcConfiguration/EventMeshTCPConfiguration * Add field notEmpty for @configFiled [1] If it cannot be empty but is empty, an exception is thrown * Change the SPI RocketMQ config to new framework * Change the SPI kafka config to new framework * Change the SPI Redis config to new framework * Change the SPI knative config to new framework * Change the SPI pravega config to new framework * Change the SPI pulsar config to new framework * Change the SPI rabbitmq config to new framework * Change the SPI Prometheus config to new framework * Change the SPI auth-http-basic config to new framework * Change the SPI trace-api config to new framework * Change the SPI pinpoint config to new framework * Change the SPI zipkin config to new framework * Use getter/setter methods to access EventMeshGrpcConfiguration * Use getter/setter methods to access EventMeshHTTPConfiguration * Enhanced Configuration management * remove temporary blocking @ignore * fix styleCheck * fix UT * rename ConfigService method * Revision review comments * Fixed code review comments [1] save the last accessible status of reflection field and recovery it after custom operation * Fixed code review comments [1] CLASS_PATH_PREFIX/FILE_PATH_PREFIX constants optimization [2] Some other code details optimization * Fixed code review comments [1] add UT for ConfigService#getConfig(ConfigInfo configInfo) Co-authored-by: githublaohu <2372554140@qq.com> Co-authored-by: mike_xwm <mike_xwm@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2576.
Motivation
Enhancement the config manage for project
Modifications
[1] Split the converter classes in Convert into separate files
[2] Add the converter field to ConfigFiled, used to specify the converter class of the field
Documentation