Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #285] add SubscriptionManager #2856

Merged
merged 6 commits into from
Jan 8, 2023

Conversation

wqliang
Copy link
Contributor

@wqliang wqliang commented Jan 8, 2023

Fixes #2852 .

Motivation

  • add SubscriptionManager to manage client info adn sub topics;
  • reduce redundant code for updating client info and sub topics info;

Modifications

  • add SubscriptionManager and move 'localConsumerGroupMapping' 'localClientInfoMapping' from EventMeshHTTPServer to SubscriptionManager;
  • use SubscriptionManager to registerClient on SubscribeProcessor;
  • use SubscriptionManager to registerClient on LocalSubscribeEventProcessor;
  • use SubscriptionManager to update sub topics on SubscribeProcessor;
  • use SubscriptionManager to update sub topics on LocalSubscribeEventProcessor;

Documentation

  • Does this pull request introduce a new feature? (no)

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #2856 (f153882) into master (3bda8fb) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2856      +/-   ##
============================================
+ Coverage     11.61%   11.64%   +0.02%     
  Complexity      911      911              
============================================
  Files           503      505       +2     
  Lines         28093    28028      -65     
  Branches       2876     2859      -17     
============================================
  Hits           3264     3264              
+ Misses        24533    24468      -65     
  Partials        296      296              
Impacted Files Coverage Δ
...tmesh/runtime/admin/handler/HTTPClientHandler.java 0.00% <0.00%> (ø)
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.00% <0.00%> (ø)
...che/eventmesh/runtime/boot/EventMeshTCPServer.java 0.57% <ø> (+<0.01%) ⬆️
...he/eventmesh/runtime/core/consumer/ClientInfo.java 0.00% <0.00%> (ø)
...esh/runtime/core/consumer/SubscriptionManager.java 0.00% <0.00%> (ø)
.../runtime/core/consumergroup/ConsumerGroupConf.java 0.00% <0.00%> (ø)
...protocol/http/consumer/HttpClientGroupMapping.java 0.00% <0.00%> (ø)
...re/protocol/http/processor/HeartBeatProcessor.java 0.00% <0.00%> (ø)
...l/http/processor/LocalSubscribeEventProcessor.java 0.00% <0.00%> (ø)
...http/processor/LocalUnSubscribeEventProcessor.java 0.00% <0.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonyangx jonyangx merged commit d6ae87a into apache:master Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants