Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2576] Improve configuration management of WebHook #2861

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

eight-nines
Copy link
Contributor

Fixes #2576.

Motivation

Enhancement the config manage for project

Modifications

[1] WebHook config improve
[2] WebHook config UT

Documentation

  • Does this pull request introduce a new feature? no

@eight-nines eight-nines changed the base branch from master to config-manage-improve January 8, 2023 15:00
@eight-nines eight-nines closed this Jan 8, 2023
@eight-nines eight-nines reopened this Jan 8, 2023
@eight-nines eight-nines closed this Jan 9, 2023
@eight-nines eight-nines reopened this Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #2861 (2cd03c0) into config-manage-improve (74025dc) will increase coverage by 0.02%.
The diff coverage is 61.70%.

@@                     Coverage Diff                     @@
##             config-manage-improve    #2861      +/-   ##
===========================================================
+ Coverage                    12.36%   12.38%   +0.02%     
- Complexity                     997     1014      +17     
===========================================================
  Files                          514      524      +10     
  Lines                        28570    28810     +240     
  Branches                      3021     3050      +29     
===========================================================
+ Hits                          3532     3569      +37     
- Misses                       24754    24955     +201     
- Partials                       284      286       +2     
Impacted Files Coverage Δ
.../apache/eventmesh/common/config/ConfigService.java 36.00% <0.00%> (-0.49%) ⬇️
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.00% <ø> (ø)
...che/eventmesh/runtime/boot/EventMeshTCPServer.java 0.00% <ø> (ø)
...e/eventmesh/webhook/receive/WebHookController.java 0.00% <0.00%> (ø)
...ook/receive/storage/HookConfigOperationManage.java 0.00% <0.00%> (ø)
...mmon/config/convert/converter/ObjectConverter.java 59.52% <33.33%> (-0.98%) ⬇️
...bhook/admin/AdminWebHookConfigOperationManage.java 70.83% <90.00%> (+70.83%) ⬆️
...e/eventmesh/webhook/config/AdminConfiguration.java 90.00% <90.00%> (ø)
...h/webhook/receive/config/ReceiveConfiguration.java 90.00% <90.00%> (ø)
...e/eventmesh/common/config/CommonConfiguration.java 76.92% <100.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[1] WebHook config improve
[2] WebHook config UT
@eight-nines eight-nines reopened this Jan 9, 2023
[1] If String config field not a number, an exception is thrown
@xwm1992 xwm1992 merged commit 4c67dcd into apache:config-manage-improve Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Enhancement the config manage for project
2 participants