Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4069]Add TLSConfig to registry plugin Consul. #4070

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

pandaapo
Copy link
Member

@pandaapo pandaapo commented Jun 4, 2023

Fixes #4069.

Motivation

The registry plugin Consul does not support TLSConfig for now.

Modifications

Add TLSConfig to registry plugin Consul.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #4070 (e8240ce) into master (fb144bb) will increase coverage by 0.01%.
The diff coverage is 32.14%.

❗ Current head e8240ce differs from pull request most recent head 71b0fb6. Consider uploading reports for the commit 71b0fb6 to get more accurate results

@@             Coverage Diff              @@
##             master    #4070      +/-   ##
============================================
+ Coverage     14.22%   14.23%   +0.01%     
- Complexity     1328     1330       +2     
============================================
  Files           580      581       +1     
  Lines         28856    28882      +26     
  Branches       2792     2795       +3     
============================================
+ Hits           4105     4112       +7     
- Misses        24361    24378      +17     
- Partials        390      392       +2     
Impacted Files Coverage Δ
...ntmesh/registry/consul/config/ConsulTLSConfig.java 28.57% <28.57%> (ø)
...registry/consul/service/ConsulRegistryService.java 38.37% <33.33%> (-3.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit b85d890 into apache:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add TLSConfig to registry plugin Consul.
5 participants