Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4206] Add github-action 'stale' bot to this repo #4207

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Jul 8, 2023

Fixes #4206.

Motivation

Please see #4206.

If an issue or pull request remains inactive for a certain period of time, it will be automatically closed.

Modifications

I have set up a whitelist for pull requests with the help wanted label and for issues with the labels pinned, discussion, good first issue, Hacktoberfest and help wanted.

For Contributors

The good first issue list is maintained by @Alonexc . If a pull request remains inactive for an extended period, it will be closed. However, if the assignee has not even submitted the pull request, it cannot be automatically handled. This decision depends on Alonexc's preference. If maintaining it becomes too burdensome, I suggest removing this whitelist and adding the help wanted label to good first issues that have been inactive for a long time and triggered the stale status.

For Maintainers

Pinned issues and to-do lists need to be labeled with the pinned or discussion or help wanted tag.

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Alonexc
Alonexc previously approved these changes Jul 10, 2023
@Pil0tXia
Copy link
Member Author

@Alonexc Hello Alonexc, I noticed that not all of the good first issues were labeled good first issue, as a resualt the good first issue label added to exempt (or whitelist) will not cover all of the good first issues.

Considering this situation and comparing with the solution I mentioned which "removing this whitelist and adding the help wanted label to good first issues that have been inactive for a long time and triggered the stale status", would you think it would be better to remove the good first issue exempt?

@Alonexc
Copy link
Contributor

Alonexc commented Jul 10, 2023

Hi, I think it's OK, the tag will be marked when it's raised, and if some issues are fixed, I'll go ahead and close it too.

@Pil0tXia
Copy link
Member Author

Thank you for your reply. I have removed good first issue and Hacktoberfest label exempt. You will get notified when assignees appear to be inactive.

@Pil0tXia
Copy link
Member Author

My fork repo has enabled Continuous Integration, and the latest commit passed all the checks.
https://github.com/Pil0tXia/eventmesh/actions/runs/5503786654/jobs/10029334958

@xwm1992 Please add pinned tag for #3873 and #888. Thanks.

Here is the list of issues included in #3873 that are still unclaimed at this time, please add help wanted tag to keep them:

Besides, maybe you would like to add this issue into What are we doing now?: #2179

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.55%. Comparing base (1ad5fdf) to head (215ff28).
Report is 35 commits behind head on master.

❗ Current head 215ff28 differs from pull request most recent head f305435. Consider uploading reports for the commit f305435 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #4207       +/-   ##
=============================================
+ Coverage          0   17.55%   +17.55%     
- Complexity        0     1778     +1778     
=============================================
  Files             0      797      +797     
  Lines             0    29871    +29871     
  Branches          0     2582     +2582     
=============================================
+ Hits              0     5243     +5243     
- Misses            0    24145    +24145     
- Partials          0      483      +483     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pil0tXia
Copy link
Member Author

I added weopen-star, GLCC, summer of code label to the exempt. These kinds of open source events go on for a long time. It should be nice now.

@Pil0tXia
Copy link
Member Author

@Pil0tXia
Copy link
Member Author

Change log:

  • Never close a PR
  • Stale PR message encourages communication
  • Close timer after stale message extended to 14 days

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Jan 10, 2024

@xwm1992 @pandaapo @mxsm

I have updated this action. Now, the Stale Bot will not close any issues or pull requests. I prefer to have it simply provide reminders and guide contributors on how to advance their work with the help of the community.

In my opinion, the most effective way for reviewers to use the Stale Bot is to combine it with the mailing list. Comments sent by the Stale Bot in the issue@eventmesh.apache.org can be archived into a dedicated folder. Whenever this folder receives a new email, reviewers can check the corresponding pull request to see the progress.

I have added exclusion labels for issues that do not require comments from the Stale Bot.

Let me know your thoughts on this.


The Stale PR message:

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.


The Stale Issue message:

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.


For the parameter days-before-pr-stale: 60, I set it to 60 because, apart from Dependabot's PR, there were 19 inactive PRs in the past 90 days, 20 inactive PRs in the past 60 days, and 21 inactive PRs in the past 30 days. Therefore, I feel that 60 is a reasonable value.

Days Before PR Stale Number of Inactive PRs
90 19
60 20
30 21

For the parameter days-before-issue-stale: 90, I feel that 90 is a reasonable value:

Days Before Issue Stale Number of Inactive Issues
120 152
90 155
60 160
30 174

xwm1992
xwm1992 previously approved these changes Mar 28, 2024
Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia Pil0tXia requested review from xwm1992 and mxsm March 28, 2024 10:09
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia
Copy link
Member Author

@xwm1992 Would you please kindly re-approve it

@Pil0tXia Pil0tXia merged commit 6594588 into apache:master Apr 3, 2024
9 checks passed
@Pil0tXia Pil0tXia deleted the pil0txia_action_4206 branch April 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add 'stale' github-action bot to this repo
4 participants