Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #436] Fix typo errors for runtime package #441

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

liutaohua
Copy link
Contributor

No description provided.

@qqeasonchen
Copy link
Contributor

@liutaohua Can you fix all the typos in one PR? btw the title should follow the [ISSUE # ] format.

@ruanwenjun
Copy link
Member

@liutaohua Agree with @qqeasonchen, it may not be a problem in other scenarios, but currently, since many pr may change these file, frequent code change may cause others need to solve the conflict frequently.

@liutaohua
Copy link
Contributor Author

Yes, I agree with you, but first of all, I don't study full-time, so I can only say to combine everything I learn every time.
Second, if you think the typo is irrelevant, I can close the pr and no longer submit the relevant content...
Thank you

@qqeasonchen
Copy link
Contributor

@liutaohua Understood, Thank You for your time, Any contributions are welcomed, but you can submit them one time As comlplete As You can.

@qqeasonchen qqeasonchen changed the title Fix typo for runtime package [ISSUE #436] Fix typo erros Jul 16, 2021
@qqeasonchen qqeasonchen changed the title [ISSUE #436] Fix typo erros [ISSUE #436] Fix typo errors Jul 16, 2021
@qqeasonchen
Copy link
Contributor

qqeasonchen commented Jul 16, 2021

@liutaohua I reopened the issue #436 and leave this pr pending so that you can add new commits here.

@liutaohua
Copy link
Contributor Author

@liutaohua I reopened the issue #436 and leave this pr pending so that you can add new commits here.

thanks Chen

@liutaohua liutaohua changed the title [ISSUE #436] Fix typo errors [ISSUE #436] Fix typo errors for runtime package Jul 16, 2021
@liutaohua
Copy link
Contributor Author

@liutaohua I reopened the issue #436 and leave this pr pending so that you can add new commits here.

I think the scope of the title is a bit too large. I'm not a spell checker, so I can't bear having to open every class once and fix all the typo.

I gave a preview of the basic logic of Runtime, and I thought that at least there were no obvious errors in Runtime, and that this PR could be incorporated.

If you think you need me to incorporate all the mistakes I found in the learning process into this PR, please keep it open for a long time. I will resolve the conflicts in an indefinite amount of time, or someone else will remember to fix them during development

@qqeasonchen qqeasonchen merged commit ae25d2e into apache:develop Jul 16, 2021
jjz921024 pushed a commit to jjz921024/incubator-eventmesh that referenced this pull request Jul 25, 2021
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this pull request Dec 27, 2021
xwm1992 pushed a commit that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants