-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#4459] Fix unchecked call to a original type member #4506
Conversation
...urity-auth-token/src/main/java/org/apache/eventmesh/auth/token/impl/auth/AuthTokenUtils.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4506 +/- ##
============================================
- Coverage 15.47% 15.47% -0.01%
- Complexity 1452 1454 +2
============================================
Files 691 692 +1
Lines 28106 28103 -3
Branches 2626 2612 -14
============================================
- Hits 4349 4348 -1
+ Misses 23312 23310 -2
Partials 445 445
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
||
Set<String> groupTopics = (Set<String>) aclProperties.getExtendedField("topics"); | ||
Object topics = aclProperties.getExtendedField("topics"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modification can have impacts on code readability and it is recommended to add some comments if there is no better solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4459 .
Modifications
Fix unchecked call to a original type member