Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#4459] Fix unchecked call to a original type member #4506

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

yanrongzhen
Copy link
Contributor

Fixes #4459 .

Modifications

Fix unchecked call to a original type member

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4506 (cab56c4) into master (d3f688d) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head cab56c4 differs from pull request most recent head c0612bc. Consider uploading reports for the commit c0612bc to get more accurate results

@@             Coverage Diff              @@
##             master    #4506      +/-   ##
============================================
- Coverage     15.47%   15.47%   -0.01%     
- Complexity     1452     1454       +2     
============================================
  Files           691      692       +1     
  Lines         28106    28103       -3     
  Branches       2626     2612      -14     
============================================
- Hits           4349     4348       -1     
+ Misses        23312    23310       -2     
  Partials        445      445              
Files Coverage Δ
...sh/storage/rocketmq/consumer/PushConsumerImpl.java 24.47% <ø> (ø)
...ics/prometheus/metrics/PrometheusGrpcExporter.java 0.00% <0.00%> (ø)
...ics/prometheus/metrics/PrometheusHttpExporter.java 0.00% <0.00%> (ø)
...rics/prometheus/metrics/PrometheusTcpExporter.java 0.00% <0.00%> (ø)
...tocol/http/processor/inf/HttpRequestProcessor.java 0.00% <0.00%> (ø)
...a/org/apache/eventmesh/common/utils/TypeUtils.java 62.50% <62.50%> (ø)
...rics/prometheus/utils/PrometheusExporterUtils.java 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment on lines 139 to +140

Set<String> groupTopics = (Set<String>) aclProperties.getExtendedField("topics");
Object topics = aclProperties.getExtendedField("topics");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification can have impacts on code readability and it is recommended to add some comments if there is no better solution.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit 31b4e96 into apache:master Oct 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unchecked call to a original type member
4 participants