Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4541] eventmesh-sdk-c make error for fail to make libcurl.a #4542

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

zhurq
Copy link
Contributor

@zhurq zhurq commented Nov 6, 2023

Fixes #4541.

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

fix error in makefile.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@xwm1992 xwm1992 changed the title fix make libcurl.a error [ISSUE #4541] eventmesh-sdk-c make error for fail to make libcurl.a Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #4542 (d93d2df) into master (7438a55) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d93d2df differs from pull request most recent head 4cb28e3. Consider uploading reports for the commit 4cb28e3 to get more accurate results

@@             Coverage Diff              @@
##             master    #4542      +/-   ##
============================================
- Coverage     16.14%   16.14%   -0.01%     
+ Complexity     1581     1580       -1     
============================================
  Files           747      747              
  Lines         28965    28965              
  Branches       2541     2541              
============================================
- Hits           4677     4675       -2     
- Misses        23840    23841       +1     
- Partials        448      449       +1     

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@pandaapo pandaapo merged commit c350528 into apache:master Nov 7, 2023
5 of 7 checks passed
@pandaapo
Copy link
Member

pandaapo commented Nov 10, 2023

@zhurq
When I tried to build c sdk in github actions with the following script

run: |
git submodule init
git submodule update
make -C ./eventmesh-sdks/eventmesh-sdk-c
.

It reported the following error

Run git submodule init

Building  ==> third_party/libcurl.a...
Can't exec "aclocal": No such file or directory at /usr/local/Cellar/autoconf/2.71/share/autoconf/Autom4te/FileUtils.pm line 274.
autoreconf: error: aclocal failed with exit status: 2
make: *** [third_party/libcurl.a] Error 2

.
Do you know what the problem is?

@pandaapo
Copy link
Member

It reported the following error

@zhurq
Based on this issue microsoft/vcpkg#24870, I fixed the error above through the following script

run: |
if [[ "${{ matrix.os }}" == "ubuntu-latest" ]]; then
sudo apt-get update && sudo apt-get install -y automake autoconf-archive
elif [[ "${{ matrix.os }}" == "macOS-latest" ]]; then
brew install automake autoconf-archive
fi
make -C ./eventmesh-sdks/eventmesh-sdk-c
.
Now github actions can start compiling C sdk. Then CI seems to report a compilation error.

Building third_party/libcurl.a third_party/libjson-c.a tmp/libm.a ==> librmb.a...
ar cqT librmb.a ./tmp/*.a && echo -e 'create librmb.a\naddlib librmb.a\nsave\nend' | ar -M
ar: no output archive specified yet
Syntax error in archive script, line 1
Syntax error in archive script, line 1
make: *** [makefile:81: librmb.a] Error 9
make: Leaving directory '/home/runner/work/eventmesh/eventmesh/eventmesh-sdks/eventmesh-sdk-c'
Error: Process completed with exit code 2.

Could you take a look at what the problem is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] eventmesh-sdk-c make error for fail to make libcurl.a
3 participants