[ISSUE #476] Biz Exceptions occured in EventMesh cause connection close of client #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…develop � Conflicts: � eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/consumer/EventMeshConsumer.java � eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java � eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/Session.java � eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
Codecov Report
@@ Coverage Diff @@
## develop #477 +/- ##
=============================================
+ Coverage 9.87% 11.23% +1.36%
- Complexity 283 326 +43
=============================================
Files 228 228
Lines 10798 10816 +18
Branches 907 907
=============================================
+ Hits 1066 1215 +149
+ Misses 9635 9504 -131
Partials 97 97
Continue to review full report at Codecov.
|
ruanwenjun
reviewed
Jul 31, 2021
| @@ -77,8 +76,45 @@ protected void channelRead0(ChannelHandlerContext ctx, Package pkg) throws Excep | |||
| dispatch(ctx, pkg, startTime, cmd); | |||
| } catch (Exception e) { | |||
| logger.error("exception occurred while pkg|cmd={}|pkg={}|errMsg={}", cmd, pkg, e); | |||
There was a problem hiding this comment.
The errMsg={} in the error log is redundant. It is better midify to
logger.error("exception occurred while pkg|cmd={}|pkg={}", cmd, pkg, e);There was a problem hiding this comment.
Thank you, I got it, and I will fix it later.
xwm1992
pushed a commit
to xwm1992/EventMesh
that referenced
this pull request
Dec 27, 2021
…on close of client (apache#477) * modify:optimize flow control in downstreaming msg * modify:optimize stategy of selecting session in downstream msg * modify:optimize msg downstream,msg store in session * modify:fix bug:not a @sharable handler * modify:downstream broadcast msg asynchronously * modify:remove unneccessary interface in eventmesh-connector-api * modify:fix conflict * modify:add license in EventMeshAction * modify:fix ack problem * modify:fix exception handle when exception occured in EventMeshTcpMessageDispatcher * modify:fix log print close apache#476
xwm1992
pushed a commit
that referenced
this pull request
Aug 4, 2022
…se of client (#477) * modify:optimize flow control in downstreaming msg * modify:optimize stategy of selecting session in downstream msg * modify:optimize msg downstream,msg store in session * modify:fix bug:not a @sharable handler * modify:downstream broadcast msg asynchronously * modify:remove unneccessary interface in eventmesh-connector-api * modify:fix conflict * modify:add license in EventMeshAction * modify:fix ack problem * modify:fix exception handle when exception occured in EventMeshTcpMessageDispatcher * modify:fix log print close #476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE #476
Motivation
When the biz exception occured in EventMesh, such as, if throwing the ThreadPoolRejectException in the code of
eventMeshTCPServer.getTaskHandleExecutorService().submit(task), it will cause the connection close of client. This looks obviously unreasonable.Modifications
Catch the biz exception of EventMesh, and send the exception msg to client, not close the connection of client