Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4795] Replace this exception in beginFlush() with log print and return false #4797

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

jevinjiang
Copy link
Contributor

Fixes #4795

Motivation
replace this exception with log print and return false.

Modifications
Documentation

Does this pull request introduce a new feature? no

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pil0tXia Pil0tXia changed the title [ISSUE #4795] replace this exception with log print and return false. [ISSUE #4795] Replace this exception in beginFlush() with log print and return false Mar 20, 2024
@Pil0tXia Pil0tXia merged commit df1428f into apache:master Mar 20, 2024
9 checks passed
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize OffsetStorageWriterImpl#beginFlush method handle logic
4 participants