[ISSUE #5127] fix create topic error in Standalone mode #5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
reviewed
Nov 9, 2024
| @@ -60,25 +60,20 @@ public static StandaloneBroker getInstance() { | |||
| public MessageEntity putMessage(String topicName, CloudEvent message) { | |||
| TopicMetadata topicMetadata = new TopicMetadata(topicName); | |||
| if (!messageContainer.containsKey(topicMetadata)) { | |||
| createTopic(topicName); | |||
| throw new RuntimeException("The topic is not created"); | |||
There was a problem hiding this comment.
Better to add a topic name in logs.
|
@jevinjiang Plz check CI errors |
added 2 commits
November 16, 2024 16:07
completed~ |
qqeasonchen
previously approved these changes
Nov 18, 2024
xwm1992
approved these changes
Dec 4, 2024
MajorHe1
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5127
Motivation
bugfix in #5127
Documentation
Adjusted the judgment when creating a topic,And ask to start the channel when subscribing
Does this pull request introduce a new feature? (no)