[Issue #523] Adding Flow control RateLimiter support in Http Message Send Processor #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged from upstream
…ice, CountDownLatch and PreDestroy hook
# Conflicts: # eventmesh-test/src/main/java/org/apache/eventmesh/http/demo/sub/service/SubService.java
…ice, CountDownLatch and PreDestroy hook
…age send processors
jinrongluo
changed the title
xwm1992
requested changes
Sep 24, 2021
| @@ -39,7 +39,8 @@ | |||
| EVENTMESH_SUBSCRIBE_ERR(17, "eventMesh subscribe err"), | |||
| EVENTMESH_UNSUBSCRIBE_ERR(18, "eventMesh unsubscribe err"), | |||
| EVENTMESH_HEARTBEAT_ERR(19, "eventMesh heartbeat err"), | |||
| EVENTMESH_ACL_ERR(20, "eventMesh acl err"); | |||
| EVENTMESH_ACL_ERR(20, "eventMesh acl err"), | |||
| EVENTMESH_HTTP_MES_SEND_OVER_LIMIT_ERR(20, "eventMesh http msg send over the limit, "); | |||
There was a problem hiding this comment.
Thanks @xwm1992 I fix the error code to make it as 21.
Adding new commit to this PR
Codecov Report
@@ Coverage Diff @@
## develop #524 +/- ##
=============================================
- Coverage 11.03% 10.99% -0.04%
Complexity 376 376
=============================================
Files 257 257
Lines 12157 12191 +34
Branches 1032 1036 +4
=============================================
Hits 1341 1341
- Misses 10701 10735 +34
Partials 115 115
Continue to review full report at Codecov.
|
xwm1992
approved these changes
Sep 27, 2021
xwm1992
pushed a commit
to xwm1992/EventMesh
that referenced
this pull request
Dec 27, 2021
…ssage Send Processor (apache#524) * [Issue apache#337] Fix HttpSubscriber startup issue * [Issue apache#337] test commit * [Issue apache#337] revert test commit * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue apache#337] Address code review comment for Subscriber Demo App * Issue apache#523 adding FlowControl Ratelimiter support for Http message send processors * [Issue apache#523] Fixing the Eventmesh ratelimit error return code. Co-authored-by: j00441484 <jin.rong.luo@huawei.com>
xwm1992
pushed a commit
that referenced
this pull request
Aug 4, 2022
…Send Processor (#524) * [Issue #337] Fix HttpSubscriber startup issue * [Issue #337] test commit * [Issue #337] revert test commit * [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue #337] Enhance Http Demo Subscriber by using ExecutorService, CountDownLatch and PreDestroy hook * [Issue #337] Address code review comment for Subscriber Demo App * Issue #523 adding FlowControl Ratelimiter support for Http message send processors * [Issue #523] Fixing the Eventmesh ratelimit error return code. Co-authored-by: j00441484 <jin.rong.luo@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #523 Adding Flow control RateLimiter support in Http Message Send Processor
Motivation
In Eventmesh runtime, there is flow control using RateLimiter in TCP MessageTransfer processor, and HTTP Batch Message send processor. However flow control is missing in Http MessageSend (Sync & Async) procrssors.
I have implemented RateLimiter for Http Message Send processors, and would like to contribute.
Modifications
Adding RateLimiter to Http Message Send Processor.
Using property file to set the rate limit