Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #956] add trace for tcp protocol in eventmesh-runtime #960

Merged
merged 5 commits into from
Jun 24, 2022
Merged

[ISSUE #956] add trace for tcp protocol in eventmesh-runtime #960

merged 5 commits into from
Jun 24, 2022

Conversation

lrhkobe
Copy link
Contributor

@lrhkobe lrhkobe commented Jun 23, 2022

Fixes ISSUE #956 .

Motivation

  • In cloud-native application scenarios, the flow of events is very complex and common, event tracking is very meaningful and important for analyzing problems

Modifications

  • Add trace buried point for tcp protocol in eventmesh-runtime
  • Record specific attributes to the trace, for example, the time of the event life cycle, the eventmesh ip that the event passed through

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #960 (db3bd54) into master (f6206b1) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             master    #960      +/-   ##
===========================================
- Coverage      8.53%   8.39%   -0.15%     
+ Complexity      529     528       -1     
===========================================
  Files           356     362       +6     
  Lines         22766   23167     +401     
  Branches       2496    2544      +48     
===========================================
+ Hits           1943    1944       +1     
- Misses        20673   21072     +399     
- Partials        150     151       +1     
Impacted Files Coverage Δ
...apache/eventmesh/runtime/boot/EventMeshServer.java 0.00% <0.00%> (ø)
...ventmesh/runtime/constants/EventMeshConstants.java 0.00% <ø> (ø)
...ocol/tcp/client/EventMeshTcpMessageDispatcher.java 0.00% <0.00%> (ø)
.../protocol/tcp/client/group/ClientGroupWrapper.java 0.00% <0.00%> (ø)
...rotocol/tcp/client/session/push/SessionPusher.java 0.00% <0.00%> (ø)
...rotocol/tcp/client/session/send/SessionSender.java 0.00% <0.00%> (ø)
.../protocol/tcp/client/task/MessageTransferTask.java 0.00% <0.00%> (ø)
.../apache/eventmesh/runtime/trace/AttributeKeys.java 0.00% <0.00%> (ø)
...java/org/apache/eventmesh/runtime/trace/Trace.java 0.00% <0.00%> (ø)
...org/apache/eventmesh/runtime/trace/TraceUtils.java 0.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6206b1...db3bd54. Read the comment docs.

Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit 2cace5f into apache:master Jun 24, 2022
@ruanwenjun ruanwenjun added this to the 1.5.0 milestone Jun 25, 2022
xwm1992 added a commit that referenced this pull request Aug 4, 2022
[ISSUE #956] add trace for tcp protocol in eventmesh-runtime
close #956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants