Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36528] [Kubernetes Operator] Update org.apache.avro from 1.8.2 to 1.12.0 #901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kartik-3513
Copy link
Contributor

What is the purpose of the change

This PR updates the dependency "org.apache.avro:avro" version from 1.8.2 to 1.12.0

Brief change log

The transitive dependency "org.apache.avro:avro" version 1.8.2 present in beam-sdks-java-core under flink-beam-example module has 2 direct and 12 vulnerabilities from dependent packages. Updating it to 1.12.0 removes all of them. List can be found here: https://mvnrepository.com/artifact/org.apache.avro/avro/1.8.2

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@gyfora
Copy link
Contributor

gyfora commented Oct 14, 2024

This PR only contains comments + it is not an issue as it is related to an example. I suggest closing the jira ticket and the PR without merging

@kartik-3513
Copy link
Contributor Author

I mistakenly pushed the wrong state of code, I have updated it, please check again.

@gyfora
Copy link
Contributor

gyfora commented Oct 14, 2024

Still an example so we should probably not make this change and simply close it

@gyfora
Copy link
Contributor

gyfora commented Oct 14, 2024

We can update beam dependency in the future instead

@kartik-3513
Copy link
Contributor Author

Sure, thanks for your input.

@kartik-3513
Copy link
Contributor Author

I have evaluated updating beam-dependency, we can proceed with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants