Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muchos102- Add Stop and start options without wiping. #359

Closed
wants to merge 45 commits into from

Conversation

plainolneesh
Copy link
Contributor

This pull request is in reference to #102

@arvindshmicrosoft
Copy link
Member

@plainolneesh thank you for the contribution - is this to be considered on top of PR #338 for adding the ELK stack? It looks like this branch contains the full set of changes in #338 as well. I wonder if you can separate these changes to be based on current master so that it is easier to review the discrete changes for supporting stop and `start, independent of the changes for the ELK stack...

@plainolneesh
Copy link
Contributor Author

@plainolneesh thank you for the contribution - is this to be considered on top of PR #338 for adding the ELK stack? It looks like this branch contains the full set of changes in #338 as well. I wonder if you can separate these changes to be based on current master so that it is easier to review the discrete changes for supporting stop and `start, independent of the changes for the ELK stack...

@arvindshmicrosoft I can definitely do that. I will cancel this pull request and open a new one. Not a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants