Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style-guide.adoc with 4 proper rendering of "`" character #2119

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

fanofxiaofeng
Copy link
Contributor

@fanofxiaofeng fanofxiaofeng commented Nov 9, 2024

As mentioned in Example 6 in https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#text-formatting,
two consecutive "`" character can be used to render unconstrained italic (I think it means italic that are not constrained to boundary of words)
assert
Throwable

There are four places that "`" is not rendered as expected in this adoc file (as shown above), I tried to fix all of them.
Please help review. Thanks

As mentioned in Example 6 in https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#text-formatting, two consecutive "`" character can be used to render unconstrained italic
@paulk-asert paulk-asert merged commit 11b663a into apache:master Nov 9, 2024
18 checks passed
@paulk-asert
Copy link
Contributor

Thanks for spotting those. I suspect they might have worked as is on a very old version of Asciidoc. In any case, I think the sentence could be made clearer without the pluralization of those keywords. I might try to reword if I can find time.

@fanofxiaofeng fanofxiaofeng deleted the patch-1 branch November 9, 2024 03:46
@fanofxiaofeng
Copy link
Contributor Author

OK, thanks for the details.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.6608%. Comparing base (6cd477b) to head (31bcef4).
Report is 329 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2119        +/-   ##
==================================================
+ Coverage     68.5957%   68.6608%   +0.0651%     
- Complexity      29233      29416       +183     
==================================================
  Files            1426       1427         +1     
  Lines          113494     113631       +137     
  Branches        19548      19634        +86     
==================================================
+ Hits            77852      78020       +168     
+ Misses          29088      29047        -41     
- Partials         6554       6564        +10     

see 94 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants