HIVE-28656: Improve HPL/SQL tests #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two tests in `hplsql` module make assertions on the output to `System.out` and `System.err`. This makes the tests fragile to any other output that might appear there (see apache/logging-log4j2#2791 for example). This PR introduces a custom `Console` implementation to capture the output of these tests and make them independent from whatever is printed to the standard output and error descriptors.
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
|
This was referenced Aug 16, 2024
difin
reviewed
Sep 16, 2024
hplsql/src/test/java/org/apache/hive/hplsql/TestHplsqlLocal.java
Outdated
Show resolved
Hide resolved
difin
reviewed
Sep 16, 2024
hplsql/src/test/java/org/apache/hive/hplsql/TestHplsqlOffline.java
Outdated
Show resolved
Hide resolved
|
|
@ppkarwasz Thanks for your fix. |
|
@zhangbutao: I created HIVE-28656. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a custom
Consoleimplementation to capture the output of twohplsqltests and make them independent from whatever is printed toSystem.outandSystem.err.Why are the changes needed?
Two tests in
hplsqlmodule (TestHplsqlLocalandTestHplsqlOffline) make assertions on the output toSystem.outandSystem.err. This makes the tests fragile to any other output that might appear there (see apache/logging-log4j2#2791 for example) and prevents them from running in parallel.Does this PR introduce any user-facing change?
No, no changes to the main code are introduced.
Is the change a dependency upgrade?
No.