Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for fix TODO comments #1466

Closed
7 tasks done
jiacai2050 opened this issue Jan 26, 2024 · 8 comments
Closed
7 tasks done

Tracking issue for fix TODO comments #1466

jiacai2050 opened this issue Jan 26, 2024 · 8 comments
Labels
contributor friendly Good for contribution feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Jan 26, 2024 •
edited
Loading

Describe This Problem

Hi community,

Our codebase contains numerous 200+ TODOs now! This indicates significant technical debt. Ignoring this will inevitably cause severe code rot.

As a community, we must acknowledge this problem affects our collective interests. While specific individuals may own portions of the code, we share responsibility for the overall health of our ecosystem.

The time to act is now. Let's work together to strengthen the foundation of our codebase before decay spreads further. Our future depends on it.

Proposal

I will begin this task by review, list the most easy TODOs first, anyone interested are welcome to help us fixing them.

Additional Context

  1. https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/benchmarks/src/merge_sst_bench.rs#L170
  2. https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/components/future_ext/src/retry.rs#L24
  3. https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/components/tracing_util/src/logging.rs#L129
  4. https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/table_engine/src/partition/rule/key.rs#L240
  5. https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/components/parquet_ext/src/prune/min_max.rs#L91
  6. https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/analytic_engine/src/instance/wal_replayer.rs#L377
  7. https://github.com/apache/incubator-horaedb/blob/63de16701c9f8614b1c7a52b15b9d2b8cbc3be59/src/analytic_engine/src/manifest/details.rs#L379
@jiacai2050 jiacai2050 added the feature New feature or request label Jan 26, 2024
@jiacai2050
Copy link
Contributor Author

jiacai2050 commented Jan 26, 2024 •
edited
Loading

To avoid conflicts with others, please lease leave an comment below to tell us which TODO you're going to fix.

@jiacai2050 jiacai2050 added good first issue Good for newcomers help wanted Extra attention is needed contributor friendly Good for contribution labels Jan 26, 2024
@Lethannn
Copy link
Contributor

Lethannn commented Feb 3, 2024

Working on "TODO: Replay logs of different tables in parallel. "

@zealchen
Copy link
Contributor

Working on "TODO: make level configurable "
Working on "TODO: add backoff "

@jiacai2050
Copy link
Contributor Author

@Lethannn It's has been quiet for a while, I wonder if there are any problems when you implement this task?

@Lethannn
Copy link
Contributor

Lethannn commented Mar 1, 2024

@Lethannn It's has been quiet for a while, I wonder if there are any problems when you implement this task?

Apologies for the silence lately. I've been dealing with some health issues over the past few weeks :( . Planning to tackle the task this weekend

@jiacai2050
Copy link
Contributor Author

I've been dealing with some health issues over the past few weeks

Sorry to hear that, let me know if you need any help.

@Lethannn Lethannn mentioned this issue Mar 4, 2024
Merged
@zealchen
Copy link
Contributor

zealchen commented Mar 8, 2024

Working on "TODO: props should be an argument " and "use NonZeroUsize "

@jiacai2050 jiacai2050 mentioned this issue Mar 11, 2024
Merged
jiacai2050 added a commit that referenced this issue Mar 11, 2024
@Lethannn @jiacai2050
feat: replay logs of different tables in parallel (#1492)
66d7a0d 
## Rationale

Related with #1466

## Detailed Changes
Replay logs of different tables in parallel

## Test Plan
CI

---------

Co-authored-by: jiacai2050 <dev@liujiacai.net>
jiacai2050 pushed a commit that referenced this issue Mar 12, 2024
@zealchen
feat: optimize minor issues (#1496)
43eb318 
## Rationale
Related with #1466

## Detailed Changes
1. Make execution_props an arguments to logical2physical.
2. Make scan_batch_size NonZeroUsize

## Test Plan
Manual test
@jiacai2050
Copy link
Contributor Author

Tasks are all finished, thanks everyone involved.

Will open an new issue to track more TODO.

zealchen pushed a commit to zealchen/incubator-horaedb that referenced this issue Apr 9, 2024
@Lethannn @jiacai2050 @zealchen
feat: replay logs of different tables in parallel (apache#1492)
d4fee8c 
## Rationale

Related with apache#1466

## Detailed Changes
Replay logs of different tables in parallel

## Test Plan
CI

---------

Co-authored-by: jiacai2050 <dev@liujiacai.net>
zealchen added a commit to zealchen/incubator-horaedb that referenced this issue Apr 9, 2024
@zealchen
feat: optimize minor issues (apache#1496)
0284a29 
## Rationale
Related with apache#1466

## Detailed Changes
1. Make execution_props an arguments to logical2physical.
2. Make scan_batch_size NonZeroUsize

## Test Plan
Manual test
zealchen pushed a commit to zealchen/incubator-horaedb that referenced this issue Apr 9, 2024
@Lethannn @jiacai2050 @zealchen
feat: replay logs of different tables in parallel (apache#1492)
2007ac3 
## Rationale

Related with apache#1466

## Detailed Changes
Replay logs of different tables in parallel

## Test Plan
CI

---------

Co-authored-by: jiacai2050 <dev@liujiacai.net>
zealchen pushed a commit to zealchen/incubator-horaedb that referenced this issue Apr 9, 2024
@Lethannn @jiacai2050 @zealchen
feat: replay logs of different tables in parallel (apache#1492)
026ed3c 
## Rationale

Related with apache#1466

## Detailed Changes
Replay logs of different tables in parallel

## Test Plan
CI

---------

Co-authored-by: jiacai2050 <dev@liujiacai.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor friendly Good for contribution feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiacai2050 @zealchen @Lethannn