Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement opentsdb query #1453

Merged
merged 19 commits into from
Mar 29, 2024
Merged

Conversation

baojinri
Copy link
Contributor

@baojinri baojinri commented Jan 22, 2024

Rationale

Opentsdb write protocol is already supported, this PR implement query protocol.

Detailed Changes

  • Convert opentsdb query requests into datafusion logical plans
  • Convert the RecordBatch format of the query results into the return response format of the opentsdb query requests

Test Plan

  • Existing tests
  • add new unit tests and integration

@ShiKaiWi
Copy link
Member

@baojinri Would you please resolve the conflicts for the following review?

@baojinri
Copy link
Contributor Author

@baojinri Would you please resolve the conflicts for the following review?

I'm resolving those conflicts now

@baojinri baojinri force-pushed the feat-opentsdb-query branch from 55829df to 9e04424 Compare January 22, 2024 09:27
@jiacai2050 jiacai2050 self-requested a review January 24, 2024 01:48
@baojinri baojinri force-pushed the feat-opentsdb-query branch from de04072 to 6c42c23 Compare January 24, 2024 02:37
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit a1db882 into apache:main Mar 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants