feat(horaectl): impl horaectl in rs #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baojinri
force-pushed
the
feat-impl-horaectl-rs
branch
from
e912dee
to
84c3c3e
Compare
jiacai2050
reviewed
Feb 27, 2024
horaectl/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| chrono = { workspace = true } | ||
| clap = { version = "=4.4.18", features = ["derive"] } |
There was a problem hiding this comment.
I thinks other crates also depend on this, make it workspace level dep.
Also check for other dependencies.
horaectl/src/cmd/cluster.rs
Outdated
| }; | ||
|
|
||
| pub fn cluster() -> Command { | ||
| Command::new("cluster") |
There was a problem hiding this comment.
Use derive macro to define command, it's more concise. See
https://github.com/apache/incubator-horaedb/blob/cd70bfc2394255afdf401a6d885de2d8bd140021/src/tools/src/bin/sst-convert.rs#L48
horaectl/src/cmd/mod.rs
Outdated
| let args = match read_args() { | ||
| Ok(args) => args, | ||
| Err(e) => { | ||
| println!("{}", e); |
There was a problem hiding this comment.
Suggested change
| println!("{}", e); | |
| println!("Read input failed, err:{e}"); |
baojinri
force-pushed
the
feat-impl-horaectl-rs
branch
from
84c3c3e
to
56bf68b
Compare
zealchen
pushed a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
## Rationale Implement horaectl using rust ## Detailed Changes - Support `cluster list`, `cluster diagnose`, `cluster schedule` ``` $ target/debug/horaectl -h HoraeCTL is a command line tool for HoraeDB Usage: horaectl [OPTIONS] [COMMAND] Commands: cluster Operations on cluster help Print this message or the help of the given subcommand(s) Options: -m, --meta <META_ADDR> Meta addr [env: HORAECTL_META_ADDR=] [default: 127.0.0.1:8080] -c, --cluster <CLUSTER_NAME> Cluster name [env: HORAECTL_CLUSTER=] [default: defaultCluster] -i, --interactive Enter interactive mode -h, --help Print help $ target/debug/horaectl cluster -h Operations on cluster Usage: horaectl cluster [OPTIONS] <COMMAND> Commands: list List cluster diagnose Diagnose cluster schedule Schedule cluster help Print this message or the help of the given subcommand(s) Options: -m, --meta <META_ADDR> Meta addr [env: HORAECTL_META_ADDR=] [default: 127.0.0.1:8080] -c, --cluster <CLUSTER_NAME> Cluster name [env: HORAECTL_CLUSTER=] [default: defaultCluster] -h, --help Print help ``` ## Test Plan - Manual tests --------- Co-authored-by: jiacai2050 <dev@liujiacai.net>
zealchen
pushed a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
## Rationale Implement horaectl using rust ## Detailed Changes - Support `cluster list`, `cluster diagnose`, `cluster schedule` ``` $ target/debug/horaectl -h HoraeCTL is a command line tool for HoraeDB Usage: horaectl [OPTIONS] [COMMAND] Commands: cluster Operations on cluster help Print this message or the help of the given subcommand(s) Options: -m, --meta <META_ADDR> Meta addr [env: HORAECTL_META_ADDR=] [default: 127.0.0.1:8080] -c, --cluster <CLUSTER_NAME> Cluster name [env: HORAECTL_CLUSTER=] [default: defaultCluster] -i, --interactive Enter interactive mode -h, --help Print help $ target/debug/horaectl cluster -h Operations on cluster Usage: horaectl cluster [OPTIONS] <COMMAND> Commands: list List cluster diagnose Diagnose cluster schedule Schedule cluster help Print this message or the help of the given subcommand(s) Options: -m, --meta <META_ADDR> Meta addr [env: HORAECTL_META_ADDR=] [default: 127.0.0.1:8080] -c, --cluster <CLUSTER_NAME> Cluster name [env: HORAECTL_CLUSTER=] [default: defaultCluster] -h, --help Print help ``` ## Test Plan - Manual tests --------- Co-authored-by: jiacai2050 <dev@liujiacai.net>
zealchen
pushed a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
## Rationale Implement horaectl using rust ## Detailed Changes - Support `cluster list`, `cluster diagnose`, `cluster schedule` ``` $ target/debug/horaectl -h HoraeCTL is a command line tool for HoraeDB Usage: horaectl [OPTIONS] [COMMAND] Commands: cluster Operations on cluster help Print this message or the help of the given subcommand(s) Options: -m, --meta <META_ADDR> Meta addr [env: HORAECTL_META_ADDR=] [default: 127.0.0.1:8080] -c, --cluster <CLUSTER_NAME> Cluster name [env: HORAECTL_CLUSTER=] [default: defaultCluster] -i, --interactive Enter interactive mode -h, --help Print help $ target/debug/horaectl cluster -h Operations on cluster Usage: horaectl cluster [OPTIONS] <COMMAND> Commands: list List cluster diagnose Diagnose cluster schedule Schedule cluster help Print this message or the help of the given subcommand(s) Options: -m, --meta <META_ADDR> Meta addr [env: HORAECTL_META_ADDR=] [default: 127.0.0.1:8080] -c, --cluster <CLUSTER_NAME> Cluster name [env: HORAECTL_CLUSTER=] [default: defaultCluster] -h, --help Print help ``` ## Test Plan - Manual tests --------- Co-authored-by: jiacai2050 <dev@liujiacai.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Implement horaectl using rust
Detailed Changes
cluster list,cluster diagnose,cluster scheduleTest Plan