chore: upgrade rustc version #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
reviewed
Feb 28, 2024
Cargo.toml
Outdated
| @@ -101,7 +101,7 @@ catalog_impls = { path = "src/catalog_impls" } | |||
| horaedbproto = { git = "https://github.com/apache/incubator-horaedb-proto.git", rev = "19ece8f771fc0b3e8e734072cc3d8040de6c74cb" } | |||
| codec = { path = "src/components/codec" } | |||
| chrono = "0.4" | |||
| clap = "3.0" | |||
| clap = "=4.4.18" | |||
There was a problem hiding this comment.
Is it necessary to lock the version to the "4.4.18"?
There was a problem hiding this comment.
The latest version of clap is currently 4.5.1. However, during local testing, I found that the latest version may not be compatible with the rustc version, so the version is temporarily locked at 4.4.18.
There was a problem hiding this comment.
Clap is very aggressive for rust version In my impression, I wonder which features do you depend on but missing from current version?
I think our user case is simple enough that there is hardly any change we need to bump it.
baojinri
force-pushed
the
chore-bump-clap
branch
from
ef2562e
to
0e692af
Compare
jiacai2050
reviewed
Mar 4, 2024
| @@ -16,5 +16,5 @@ | |||
| # under the License. | |||
|
|
|||
| [toolchain] | |||
| channel = "nightly-2023-08-28" | |||
There was a problem hiding this comment.
Try search nightly-2023-08-28 in our codebase, I remember some CI files also hard code it.
zealchen
pushed a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
## Rationale Upgrade rustc version ## Detailed Changes - upgrade rustc version - upgrade rand version - upgrade obkv-client version - upgrade clap version - Adapt to new APIs ## Test Plan CI
zealchen
pushed a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
Upgrade rustc version - upgrade rustc version - upgrade rand version - upgrade obkv-client version - upgrade clap version - Adapt to new APIs CI
zealchen
pushed a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
Upgrade rustc version - upgrade rustc version - upgrade rand version - upgrade obkv-client version - upgrade clap version - Adapt to new APIs CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Upgrade rustc version
Detailed Changes
Test Plan
CI