Feat concurrent replay wal #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add sst level config for benchmark
jiacai2050
reviewed
Mar 25, 2024
zealchen
force-pushed
the
feat_concurrent_replay_wal
branch
from
bc25819 to
b1ff6b6
Compare
jiacai2050
reviewed
Mar 25, 2024
| @@ -182,13 +182,28 @@ impl Replay for TableBasedReplay { | |||
| debug!("Replay wal logs on table mode, context:{context}, tables:{table_datas:?}",); | |||
|
|
|||
| let mut failed_tables = HashMap::new(); | |||
| let read_ctx = ReadContext { | |||
| let read_ctx = Arc::new(ReadContext { | |||
There was a problem hiding this comment.
This Arc is not required.
- for table_data in table_datas {
- let table_id = table_data.id;
- if let Err(e) = Self::recover_table_logs(context, table_data, &read_ctx).await {
+
+ let mut tasks = futures::stream::iter(
+ table_datas
+ .iter()
+ .map(|table_data| {
+ let table_id = table_data.id;
+ let read_ctx = &read_ctx;
+ async move {
+ let ret = Self::recover_table_logs(context, table_data, read_ctx).await;
+ (table_id, ret)
+ }
+ })
+ .collect::<Vec<_>>(),
+ )
+ .buffer_unordered(20);
+ while let Some((table_id, ret)) = tasks.next().await {
+ if let Err(e) = ret {
+ // If occur error, mark this table as failed and store the cause.
failed_tables.insert(table_id, e);
}
}
This compile success for me.
added 2 commits
March 25, 2024 16:45
zealchen
added a commit
to zealchen/incubator-horaedb
that referenced
this pull request
Apr 9, 2024
## Rationale Close apache#1498 ## Detailed Changes Recover table logs in parallel. ## Test Plan CI --------- Co-authored-by: chenmian.cm <chenmian.cm@antfin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #1498
Detailed Changes
Recover table logs in parallel.
Test Plan
CI