-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable layered memtable in overwrite mode #1533
Merged
jiacai2050
merged 24 commits into
apache:main
from
Rachelint:disable-layered-memtable-in-overwrite-mode
Sep 5, 2024
Merged
fix: disable layered memtable in overwrite mode #1533
jiacai2050
merged 24 commits into
apache:main
from
Rachelint:disable-layered-memtable-in-overwrite-mode
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
May 23, 2024
…dd some related checks.
ShiKaiWi
reviewed
May 24, 2024
Rachelint
force-pushed
the
disable-layered-memtable-in-overwrite-mode
branch
from
May 27, 2024 09:32
e97033b
to
a9c4041
Compare
Rachelint
force-pushed
the
disable-layered-memtable-in-overwrite-mode
branch
from
May 27, 2024 11:11
71a7944
to
bf1115a
Compare
ShiKaiWi
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jiacai2050
reviewed
Sep 5, 2024
@@ -239,6 +239,12 @@ impl<'a> Alterer<'a> { | |||
opts.sanitize(); | |||
opts | |||
}; | |||
|
|||
// We should check the options before altering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Layered memtable is only designed for append mode table now, and it shouldn't be used in overwrite mode table.
Detailed Changes
enable
field to control layered memtable's on/off.Test Plan
Test manually.
Following cases are considered:
Check and intercept the invalid table options during table create/alter
Table options new field
layered_enable
's default value when it is not found in pblayered_memtable_options
not existlayered_memtable_options
exist, andmutable_segment_switch_threshold
== 0layered_memtable_options
exist, andmutable_segment_switch_threshold
> 0