Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support INSERT INTO SELECT #1536

Merged
merged 11 commits into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions integration_tests/cases/common/dml/insert_into_select.result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said in #1538 (comment), sql with multiple tables may fails, so currently we can only enable this features in standalone mode.

In cluster mode, we can do a check to ensure tables belonging to same instance.

For now, you can move this test under local dir, something like integration_tests/cases/env/local/dml/insert_into_select.sql

Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
--
-- Licensed to the Apache Software Foundation (ASF) under one
-- or more contributor license agreements. See the NOTICE file
-- distributed with this work for additional information
-- regarding copyright ownership. The ASF licenses this file
-- to you under the Apache License, Version 2.0 (the
-- "License"); you may not use this file except in compliance
-- with the License. You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing,
-- software distributed under the License is distributed on an
-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-- KIND, either express or implied. See the License for the
-- specific language governing permissions and limitations
-- under the License.
--
DROP TABLE IF EXISTS `insert_into_select_table1`;

affected_rows: 0

CREATE TABLE `insert_into_select_table1` (
`timestamp` timestamp NOT NULL,
`value` int,
`name` string,
timestamp KEY (timestamp)) ENGINE=Analytic
WITH(
enable_ttl='false'
);

affected_rows: 0

INSERT INTO `insert_into_select_table1` (`timestamp`, `value`, `name`)
VALUES
(1, 100, "s1"),
(2, 200, "s2"),
(3, 300, "s3");

affected_rows: 3

DROP TABLE IF EXISTS `insert_into_select_table2`;

affected_rows: 0

CREATE TABLE `insert_into_select_table2` (
`timestamp` timestamp NOT NULL,
`value` int,
`name` string NULL,
timestamp KEY (timestamp)) ENGINE=Analytic
WITH(
enable_ttl='false'
);

affected_rows: 0

INSERT INTO `insert_into_select_table2` (`timestamp`, `value`)
SELECT `timestamp`, `value`
FROM `insert_into_select_table1`;

affected_rows: 3

SELECT `timestamp`, `value`, `name`
FROM `insert_into_select_table2`;

timestamp,value,name,
Timestamp(1),Int32(100),String(""),
Timestamp(2),Int32(200),String(""),
Timestamp(3),Int32(300),String(""),


DROP TABLE `insert_into_select_table1`;

affected_rows: 0

DROP TABLE `insert_into_select_table2`;

affected_rows: 0

57 changes: 57 additions & 0 deletions integration_tests/cases/common/dml/insert_into_select.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
--
-- Licensed to the Apache Software Foundation (ASF) under one
-- or more contributor license agreements. See the NOTICE file
-- distributed with this work for additional information
-- regarding copyright ownership. The ASF licenses this file
-- to you under the Apache License, Version 2.0 (the
-- "License"); you may not use this file except in compliance
-- with the License. You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing,
-- software distributed under the License is distributed on an
-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-- KIND, either express or implied. See the License for the
-- specific language governing permissions and limitations
-- under the License.
--

DROP TABLE IF EXISTS `insert_into_select_table1`;

CREATE TABLE `insert_into_select_table1` (
`timestamp` timestamp NOT NULL,
`value` int,
`name` string,
timestamp KEY (timestamp)) ENGINE=Analytic
WITH(
enable_ttl='false'
);

INSERT INTO `insert_into_select_table1` (`timestamp`, `value`, `name`)
VALUES
(1, 100, "s1"),
(2, 200, "s2"),
(3, 300, "s3");

DROP TABLE IF EXISTS `insert_into_select_table2`;

CREATE TABLE `insert_into_select_table2` (
`timestamp` timestamp NOT NULL,
`value` int,
`name` string NULL,
timestamp KEY (timestamp)) ENGINE=Analytic
WITH(
enable_ttl='false'
);

INSERT INTO `insert_into_select_table2` (`timestamp`, `value`)
SELECT `timestamp`, `value`
FROM `insert_into_select_table1`;

SELECT `timestamp`, `value`, `name`
FROM `insert_into_select_table2`;

DROP TABLE `insert_into_select_table1`;

DROP TABLE `insert_into_select_table2`;
4 changes: 3 additions & 1 deletion src/interpreters/src/factory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ impl Factory {
self.physical_planner,
self.query_runtime,
),
Plan::Insert(p) => InsertInterpreter::create(ctx, p),
Plan::Insert(p) => {
InsertInterpreter::create(ctx, p, self.query_executor, self.physical_planner)
}
Plan::Create(p) => {
CreateInterpreter::create(ctx, p, self.table_engine, self.table_manipulator)
}
Expand Down
Loading
Loading