fix: remove redundancy length field in wal record #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
feat-local-wal
branch
from
aef2a07 to
b0be8e1
Compare
jiacai2050
force-pushed
the
feat-local-wal
branch
from
b0be8e1 to
36980f4
Compare
jiacai2050
changed the title
chunshao90
reviewed
Oct 16, 2024
jiacai2050
force-pushed
the
feat-local-wal
branch
from
6180bf0 to
825f9b6
Compare
jiacai2050
force-pushed
the
feat-local-wal
branch
from
ad132e0 to
a577706
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
lengthfield is not required in wal record, it's duplicated with value_length.Detailed Changes
Test Plan
CI and manually do some benchmark with avalanche