feat: introduce TableOperator to encasulate operation of tables
#808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #808 +/- ##
==========================================
- Coverage 67.98% 67.84% -0.14%
==========================================
Files 299 300 +1
Lines 47174 47324 +150
==========================================
+ Hits 32073 32109 +36
- Misses 15101 15215 +114
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ShiKaiWi
reviewed
Apr 6, 2023
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…ache#808) * add `register_table` in `Schema`, adapt this change in volatile based schema impl. * refactor table opertations. * abort the modification in meta event service. * add table operator to meta_event_service. * add table operator to local recovery. * make clippy happy. * update integration tests. * remove useless table operation methods, and schema id in related requests. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Now, we directly call the method in
Schemafor table operations, that led to tons of dulicated codes(e.g. create and drop inmeta event serviceandinterpreter,openinmeta event servieandlocal recovery).In this pr,
TableOperatoris introduced to escasulate such operations for eliminating the duplicateds.What changes are included in this PR?
TableOperator.open tableandclose tableSchema, and addregister_tableandunregister_table.table_enginefor opening and closing.TableOperator.Are there any user-facing changes?
None.
How does this change test
Test exist tests.