Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shard related methods to table engine #897

Merged

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #
Part of #799

Rationale for this change

  • Add open_shard and close_shard methods into TableEngine.
  • Impl the methods above on demand.

What changes are included in this PR?

See above.

Are there any user-facing changes?

None.

How does this change test

Test by ut.

@Rachelint Rachelint changed the title Add shard related methods to table engine feat: add shard related methods to table engine May 16, 2023
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 12f8656 into apache:main May 22, 2023
@Rachelint Rachelint deleted the add-shard-related-methods-to-table-engine branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants