Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HUDI-6538] Refactor methods in TimelineDiffHelper class #10938

Merged
merged 1 commit into from
Apr 1, 2024
Merged

[HUDI-6538] Refactor methods in TimelineDiffHelper class #10938

merged 1 commit into from
Apr 1, 2024

Conversation

wombatu-kun
Copy link
Contributor

@wombatu-kun wombatu-kun commented Mar 29, 2024 •
edited by yihua
Loading

Change Logs

Refactor methods in TimelineDiffHelper class to address following comment #9007 (comment)

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

none

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Mar 29, 2024
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@wombatu-kun
Copy link
Contributor Author

@nsivabalan this refactoring is made addressing the code you proposed in comment to other PR.
Could you please review it?

@danny0405 danny0405 merged commit 44ab6f3 into apache:master Apr 1, 2024
41 checks passed
yihua pushed a commit that referenced this pull request May 14, 2024
@wombatu-kun @yihua
[HUDI-6538] Refactor methods in TimelineDiffHelper class (#10938)
58b0d24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danny0405 danny0405 danny0405 approved these changes

Assignees
No one assigned
Labels
code-refactor size:S PR with lines of changes in (10, 100]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wombatu-kun @hudi-bot @danny0405