[HUDI-7557] Fix incremental cleaner when commit for savepoint removed #10946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Apr 1, 2024
| @@ -245,6 +245,7 @@ private List<String> getPartitionsFromDeletedSavepoint(HoodieCleanMetadata clean | |||
| Option<HoodieInstant> instantOption = hoodieTable.getCompletedCommitsTimeline().filter(instant -> instant.getTimestamp().equals(savepointCommit)).firstInstant(); | |||
| if (!instantOption.isPresent()) { | |||
| LOG.warn("Skipping to process a commit for which savepoint was removed as the instant moved to archived timeline already"); | |||
| return Stream.empty(); | |||
There was a problem hiding this comment.
Does this mean the archived savepoint partition never got cleaned?
nsivabalan
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This block of code is buggy when commit which was savepointed has been removed or archived. The PR handles the empty
Option. This code path is exercised only when incremental cleaning is enabled and there are savepoints in the timeline.Impact
Bug fix for incremental cleaner.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist