[HUDI-8212] Add extra config of billing project ID for BigQuery sync #11988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
changed the title
yihua
approved these changes
Oct 5, 2024
| properties.setProperty(BigQuerySyncConfig.BIGQUERY_SYNC_DATASET_NAME.key(), TEST_DATASET); | ||
| properties.setProperty(HoodieSyncConfig.META_SYNC_BASE_PATH.key(), tempDir.toString()); | ||
| properties.setProperty(BigQuerySyncConfig.BIGQUERY_SYNC_REQUIRE_PARTITION_FILTER.key(), "true"); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(booleans = {true, false}) | ||
| void testCreateOrUpdateTableUsingManifestWithBillingProjectId(boolean setBillingProjectId) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
When the big query dataset project id is different than billing project id, the job has to be submitted in different project.
Impact
none
Risk level (write none, low medium or high below)
low
Documentation Update
Big Query sync Documentation update is necessary for the extra config. Will raise a PR for that too.
Contributor's checklist