[HUDI-4468] Simplify TimeTravel logic for Spark #12270
Open
+3,254
−15,854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
After spark3.3 support TimeTravel SQL and Logical Plan, remove the implementation in hudi, remain
index
DML SQLcode detail:
before spark3.3, spark not support timetravel sql, so hudi supports the full DQL query syntax for timetravel.
now, we remove it, therefore, a large portion of the DQL syntax parsing will not be used; we only need to support Hudi's custom implementation of the DDL syntax related to indexing.
g4 file
queryStatement
dmlStatement
createTable
in HoodieSqlBase.g4, it's for timetravelindex
need.astBuilder
Impact
in spark, TIMESTAMP dataType is
TimestampType
, VERSION isString
. And the hoodie instance time format is not legal for spark to parse.And from the perspective of usage, the concept of HUDI's timestamp concept is more suitable for using VERSION, so in this pr:
Risk level (write none, low medium or high below)
low
Documentation Update
spark Time Travel Query tutorial, update
Contributor's checklist