Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

fix: Add catalog pages to docs. #284

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

liurenjie1024
Copy link
Contributor

docs/content/catalog.md Outdated Show resolved Hide resolved
@nastra
Copy link
Contributor

nastra commented Oct 20, 2023

I think the initial goal was to have a Concepts section on the website and that catalog page was the first page to be shown here. So I think what we want here is

diff --git a/docs/config.toml b/docs/config.toml
index 2722d7d0..a918b64a 100644
--- a/docs/config.toml
+++ b/docs/config.toml
@@ -56,6 +56,8 @@ home = [ "HTML", "RSS", "SearchIndex" ]
     { name = "Multi-Engine Support", parent = "Project", pre = "relative", url = "../../multi-engine-support", weight = 450 },
     { name = "How To Release", parent = "Project", pre = "relative", url = "../../how-to-release", weight = 500 },
     { name = "Terms", parent = "Project", pre = "relative", url = "../../terms", weight = 600 },
+    { name = "Concepts", weight = 1150 },
+    { name = "Catalogs", url = "/concepts/catalog", parent = "Concepts" },
     { name = "ASF", weight = 1200 },
     { name = "License", identifier = "_license", parent = "ASF", url = "https://www.apache.org/licenses/" },
     { name = "Security", identifier = "_security", parent = "ASF", url = "https://www.apache.org/security/" },
diff --git a/landing-page/config.toml b/landing-page/config.toml
index f14d2ff1..e95312de 100644
--- a/landing-page/config.toml
+++ b/landing-page/config.toml
@@ -67,6 +67,8 @@ home = [ "HTML", "RSS", "SearchIndex" ]
     { name = "Multi-Engine Support", url = "/multi-engine-support", parent = "Project", weight = 450 },
     { name = "How To Release", parent = "Project", url = "/how-to-release", weight = 500 },
     { name = "Terms", url = "/terms", parent = "Project", weight = 600 },
+    { name = "Concepts", weight = 1150 },
+    { name = "Catalogs", url = "/concepts/catalog", parent = "Concepts" },
     { name = "ASF", weight = 1200 },
     { name = "License", identifier = "_license", parent = "ASF", url = "https://www.apache.org/licenses/" },
     { name = "Security", identifier = "_security", parent = "ASF", url = "https://www.apache.org/security/" },

@liurenjie1024
Copy link
Contributor Author

Hi, @nastra I followed you instruction to add it, it goes well mostly but with one thing:
image

The headers are wrapped, do you know how to fix it? I'm not familiar with hugo.

@liurenjie1024
Copy link
Contributor Author

Hi, @nastra I followed you instruction to add it, it goes well mostly but with one thing: image

The headers are wrapped, do you know how to fix it? I'm not familiar with hugo.

Never mind, my friend helped me to solve it.

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @liurenjie1024 for fixing this

@nastra nastra merged commit 4b98185 into apache:main Oct 23, 2023
@liurenjie1024 liurenjie1024 deleted the renjie/issue-8850 branch October 23, 2023 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: The doc for catalog is missing.
2 participants