Skip to content

Commit

Permalink
feat: Add cargo machete (#448)
Browse files Browse the repository at this point in the history
* adding cargo machete to check unused dependencies

* remove default values

* adding a tag version instead of main

* running cargo machete natively

* removing unused dependency urlencoding

* bug fixes
  • Loading branch information
vaibhawvipul authored Jul 9, 2024
1 parent 8782665 commit 48f9e3e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ jobs:
- name: Cargo sort
run: make cargo-sort

- name: Cargo Machete
run: make cargo-machete

build:
runs-on: ${{ matrix.os }}
strategy:
Expand Down
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ tempfile = "3.8"
tokio = { version = "1", default-features = false }
typed-builder = "^0.18"
url = "2"
urlencoding = "2"
uuid = "1.6.1"
volo-thrift = "0.10"
hive_metastore = "0.1.0"
Expand Down
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ cargo-sort:
cargo install cargo-sort
cargo sort -c -w

cargo-machete:
cargo install cargo-machete
cargo machete

fix-toml:
cargo install taplo-cli --locked
taplo fmt
Expand Down
1 change: 0 additions & 1 deletion crates/catalog/rest/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ serde_derive = { workspace = true }
serde_json = { workspace = true }
tokio = { workspace = true, features = ["sync"] }
typed-builder = { workspace = true }
urlencoding = { workspace = true }
uuid = { workspace = true, features = ["v4"] }

[dev-dependencies]
Expand Down

0 comments on commit 48f9e3e

Please sign in to comment.