-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
struct value design #77
Comments
I find that our struct value didn't include type info. Do we want include type info in it?
For now, I'm working on serialize/deserialize value. And both process seem can solve by second way. (pass a struct type as parameter) But I'm not sure whether there is some scenario we must include info in struct value. |
I prefer this approach. It's weird for me to store types with values, and we can always to attach type to it when necessary. |
Tracked in #96 |
Use lookup will make the memory cost if we have multiple struct with same type.
One solve way is to use
Arc<StructType>
in Struct. I try this design in icelake-io/icelake#136.Anyway I think it's ok to solve this Problem in another PR. If this desgin looks work, I'm glad to port it.
Originally posted by @ZENOTME in #20 (comment)
The text was updated successfully, but these errors were encountered: