Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Type when converting from Literal to JsonValue. #117

Closed
liurenjie1024 opened this issue Dec 11, 2023 · 0 comments · Fixed by #120
Closed

Use Type when converting from Literal to JsonValue. #117

liurenjie1024 opened this issue Dec 11, 2023 · 0 comments · Fixed by #120
Labels
good first issue Good for newcomers

Comments

@liurenjie1024
Copy link
Contributor

Currently in our conversion from Literal to JsonValue, we used stored type information in Literal. Per discussion in #77 , we decided to remove type information stored in literal, so we should remove current implementation, and add another method with following signature:

fn try_into_json(self, data_type: &Type) -> Result<JsonValue>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Conversion between literal and json should depends on type. liurenjie1024/iceberg-rust
1 participant
@liurenjie1024