Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: runtime module #233
feat: runtime module #233
Changes from 15 commits
b618eb3
410b8bb
fdfc020
01d7105
2916fb5
aea489d
0c7f6ae
dbcdef3
444704d
f4bd2cc
972bb5c
15bca8a
320c8c7
055f9bc
e8b05cb
df039d0
18c2134
9432b2d
34eb38b
8438b34
12eecb8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was wrong about the dependency resolution of cargo. If we add this line in dev.dependency, we still introduce
tokio
as dependency unconditonally. The evidency is this issue, e.g. the compilation is supposed to fail if tokio is not introduced. So we shouldThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @odysa seems this is still not removed?