feat: Define schema post order visitor. #25
Conversation
liurenjie1024
requested review from
JanKaul,
Xuanwo,
Fokko and
nastra
and removed request for
JanKaul and
Xuanwo
|
I'm working on more tests. |
There was a problem hiding this comment.
Some small comments, but looks great! Thanks @liurenjie1024 for working on this
| @@ -28,12 +28,14 @@ keywords = ["iceberg"] | |||
|
|
|||
| [dependencies] | |||
| apache-avro = "0.15.0" | |||
| serde = "^1.0" | |||
| serde = {version = "^1.0", features = ["rc"]} | |||
There was a problem hiding this comment.
I also like to live dangerous :D
There was a problem hiding this comment.
Sorry, I don't get your point here 😂
There was a problem hiding this comment.
Ah, I'm sorry. It looks like you're pulling in Release Candidates?
There was a problem hiding this comment.
Oh, I see. feature flag in rust is a tool to enable condition compilation, and 'rc' here means generating see/de code for 'Arc', and the explanation is here: https://stackoverflow.com/questions/49312600/how-do-i-serialize-or-deserialize-an-arct-in-serde.
I don't know similar concepts in java/python.
There was a problem hiding this comment.
Ah, I didn't know that. Thanks!
| } | ||
| } | ||
|
|
||
| impl Display for Schema { |
liurenjie1024
force-pushed
the
renjie/issue-spec-visitor
branch
from
1167203 to
6af0393
Compare
liurenjie1024
force-pushed
the
renjie/issue-spec-visitor
branch
from
6af0393 to
cd2e320
Compare
|
cc @Fokko Any other comments? |
More tests are following.