Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(catalogs/rest): Split user config and runtime config #431

Merged
merged 6 commits into from
Jul 4, 2024
Merged

refactor(catalogs/rest): Split user config and runtime config #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43c4b26
refactor(catalogs/rest): Split user config and runtime config
Xuanwo Jul 3, 2024
0cd3eb1
Sort cargo
Xuanwo Jul 3, 2024
eb3c78c
Fix unit tests
Xuanwo Jul 3, 2024
06f6ce3
Remove default feature of tokio
Xuanwo Jul 4, 2024
cc7d8a8
return error here
Xuanwo Jul 4, 2024
2db1e61
Return error if cred doesn't exist
Xuanwo Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
[workspace]
resolver = "2"
members = [
"crates/catalog/*",
"crates/examples",
"crates/iceberg",
"crates/integrations/*",
"crates/test_utils",
"crates/catalog/*",
"crates/examples",
"crates/iceberg",
"crates/integrations/*",
"crates/test_utils",
]

[workspace.package]
Expand Down Expand Up @@ -81,7 +81,7 @@ serde_json = "^1.0"
serde_repr = "0.1.16"
serde_with = "3.4.0"
tempfile = "3.8"
tokio = { version = "1", features = ["macros"] }
tokio = { version = "1", default-features = false }
typed-builder = "^0.18"
url = "2"
urlencoding = "2"
Expand Down
2 changes: 2 additions & 0 deletions crates/catalog/rest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,15 @@ keywords = ["iceberg", "rest", "catalog"]
# async-trait = { workspace = true }
async-trait = { workspace = true }
chrono = { workspace = true }
http = "1.1.0"
iceberg = { workspace = true }
itertools = { workspace = true }
log = "0.4.20"
reqwest = { workspace = true }
serde = { workspace = true }
serde_derive = { workspace = true }
serde_json = { workspace = true }
tokio = { workspace = true, features = ["sync"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use other crates? We are trying to avoid introducing concrete runtime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case is different here for rest-catalog since it depends on reqwest. Maybe I can move tokio dep in rest catalog?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to keep it since #233 still needs it.

typed-builder = { workspace = true }
urlencoding = { workspace = true }
uuid = { workspace = true, features = ["v4"] }
Expand Down
Loading
Loading